[whatwg/url] Ensure opaque paths always roundtrip (PR #844)

In fdaa0e5a3790693a82f578d7373f216d8fef9ac8 we tackled a problem whereby removing the fragment or query from a URL with an opaque path through the API would not make the URL roundtrip due to the opaque path being able to end in non-percent-encoded spaces.

However, this failed to address other ways of serializing the URL. As such this is a new approach whereby opaque paths simply cannot end with non-percent-encoded spaces. Enforcing this in the URL parser allows us to completely revert the aforementioned commit, greatly simplifying the API implementation.

Fixes #784.

---

Due to Interop 2024 this should not be merged until February 2025, but as this seems like the way forward I wanted to put up the fix while it was still fresh in mind. @karwa @hayatoito @valenting review appreciated!

<!--
Thank you for contributing to the URL Standard! Please describe the change you are making and complete the checklist below if your change is not editorial.

When you submit this PR, and each time you edit this comment (including checking a checkbox through the UI!), PR Preview will run and update it. As such make any edits in one go and only after PR Preview has run.

If you think your PR is ready to land, please double-check that the build is passing and the checklist is complete before pinging.
-->

- [x] At least two implementers are interested (and none opposed):
   * Chromium
   * WebKit
- [ ] [Tests](https://github.com/web-platform-tests/wpt) are written and can be reviewed and commented upon at:
   * … <!-- If these tests are tentative, link a PR to make them non-tentative. -->
- [ ] [Implementation bugs](https://github.com/whatwg/meta/blob/main/MAINTAINERS.md#handling-pull-requests) are filed:
   * Chromium: …
   * Gecko: …
   * WebKit: …
   * Deno: …
   * Node.js: …
- [ ] [MDN issue](https://github.com/whatwg/meta/blob/main/MAINTAINERS.md#handling-pull-requests) is filed: Since https://github.com/mdn/content/issues/23320 is not fixed yet we can perhaps reuse that.
- [x] The top of this comment includes a [clear commit message](https://github.com/whatwg/meta/blob/main/COMMITTING.md) to use. <!-- If you created this PR from a single commit, Github copied its message. Otherwise, you need to add a commit message yourself. -->

(See [WHATWG Working Mode: Changes](https://whatwg.org/working-mode#changes) for more details.)


<!--
    This comment and the below content is programmatically generated.
    You may add a comma-separated list of anchors you'd like a
    direct link to below (e.g. #idl-serializers, #idl-sequence):

    Don't remove this comment or modify anything below this line.
    If you don't want a preview generated for this pull request,
    just replace the whole of this comment's content by "no preview"
    and remove what's below.
-->
***
<a href="https://whatpr.org/url/844.html" title="Last updated on Dec 2, 2024, 8:51 AM UTC (f11ac03)">Preview</a> | <a href="https://whatpr.org/url/844/c3d173f...f11ac03.html" title="Last updated on Dec 2, 2024, 8:51 AM UTC (f11ac03)">Diff</a>
You can view, comment on, or merge this pull request online at:

  https://github.com/whatwg/url/pull/844

-- Commit Summary --

  * Ensure opaque paths always roundtrip

-- File Changes --

    M url.bs (86)

-- Patch Links --

https://github.com/whatwg/url/pull/844.patch
https://github.com/whatwg/url/pull/844.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/url/pull/844
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/url/pull/844@github.com>