Re: [w3c/gamepad] Add extended buttons to support trackpad (#191) (PR #196)

@marcoscaceres commented on this pull request.



> +              <li>Determine the type of the button at index |rawInputIndex|
+              [=represents a Standard Gamepad button=] or Extended button
+              types as described in the {{ExtendedMapping}} using the provided
+              buttonTypes array. If the button does not have a canonical type,
+              use GamePadButtonType.non_canonical.

This should be specified as: 

```suggestion
              <li>Let |button| be the button at index |rawInputIndex|.</li>
              <li>Let |type| be the result of determining if the |button|'s type represents a [=Standard Gamepad button|represents a Standard Gamepad button=] or an [=Extended Gamepad button|represents a Extended Gamepad button=]. If it's neither, use {{GamePadButtonType/"non_canonical"}}. 
              </li>
```

And `<dfn>represents a Standard Gamepad button</dfn>` should be defined underneath where "represents a Standard Gamepad button" is defined/

-- 
Reply to this email directly or view it on GitHub:
https://github.com/w3c/gamepad/pull/196#pullrequestreview-2030274977
You are receiving this because you are subscribed to this thread.

Message ID: <w3c/gamepad/pull/196/review/2030274977@github.com>

Received on Tuesday, 30 April 2024 06:04:56 UTC