Re: [whatwg/fetch] Add WebDriver BiDi network request logging (PR #1540)

@annevk commented on this pull request.

@jgraham apologies for the delay. Please resolve existing comment threads and maybe ping me if you haven't seen an update in a while.

I was wondering if there was a high-level description available somewhere so I can verify the various calls happen at the right time. Also happy to trust you, but it might help to have some additional review?

> @@ -2128,6 +2128,11 @@ Unless stated otherwise, it is false.
 
 <p class=note>This is for exclusive use by HTML's navigate algorithm. [[!HTML]]
 
+<p>A <a for=/>request</a> has an associated <dfn export for=request>navigation
+id</dfn> (a string). Unless stated otherwise, it is null.

"null or a string", presumably?

Also, no wrapping in inline elements.

> @@ -2169,6 +2174,15 @@ otherwise, it is unset.
 <a for=request>done flag</a>, and <a for=request>timing allow failed flag</a> are used as
 bookkeeping details by the <a for=/>fetch</a> algorithm.
 
+<p>A <a for=/>request</a> has an associated
+<dfn export for=request id=concept-request-id>request id</dfn> which is a unique
+string automatically set when the <a for=/>request</a> is created.

I'd prefer if we call this just "id" or "WebDriver id".

> @@ -2245,7 +2259,10 @@ is to return the result of <a>serializing a request origin</a> with <var>request
 
 <ol>
  <li><p>Let <var>newRequest</var> be a copy of <var>request</var>, except for its
- <a for=request>body</a>.
+ <a for=request>body</a> and <a for=request>request id</a>.
+
+ <li><p>Let <var>newRequest</var>'s <a for=request>request id</a> be a new

Set?

> +     <!-- Service Workers is responsible for emmitting the WebDriver BiDi
+          request events in this case. That's necessary to ensure that the events are
+          only generated if the service worker will handle the fetch, and to get the
+          correct event ordering in the case of network fallback -->

Slight preference for comments after the step.

> @@ -2169,6 +2174,15 @@ otherwise, it is unset.
 <a for=request>done flag</a>, and <a for=request>timing allow failed flag</a> are used as
 bookkeeping details by the <a for=/>fetch</a> algorithm.
 
+<p>A <a for=/>request</a> has an associated
+<dfn export for=request id=concept-request-id>request id</dfn> which is a unique
+string automatically set when the <a for=/>request</a> is created.
+
+Note: the [=request/request id=] is used by WebDriver-BiDi. It remains constant

`<p class=note>`

-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fetch/pull/1540#pullrequestreview-1648580661
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/fetch/pull/1540/review/1648580661@github.com>