- From: Karl <notifications@github.com>
- Date: Tue, 26 Sep 2023 00:25:58 -0700
- To: whatwg/url <url@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <whatwg/url/pull/793@github.com>
Since this branch requires that `atSignSeen` is true, we must have already emitted an `invalid-credentials` validation error and this emission must be a duplicate.
What this check is actually doing is confirming that the host is not empty before it begins parsing it, so `host-missing` is a more appropriate error to emit.
- [ ] At least two implementers are interested (and none opposed):
* …
* …
- [ ] [Tests](https://github.com/web-platform-tests/wpt) are written and can be reviewed and commented upon at:
* …
- [ ] [Implementation bugs](https://github.com/whatwg/meta/blob/main/MAINTAINERS.md#handling-pull-requests) are filed:
* Chromium: …
* Gecko: …
* WebKit: …
* Deno: …
* Node.js: …
- [ ] [MDN issue](https://github.com/whatwg/meta/blob/main/MAINTAINERS.md#handling-pull-requests) is filed: …
(See [WHATWG Working Mode: Changes](https://whatwg.org/working-mode#changes) for more details.)
You can view, comment on, or merge this pull request online at:
https://github.com/whatwg/url/pull/793
-- Commit Summary --
* Fix validation error when a URL has credentials but no host
-- File Changes --
M url.bs (2)
-- Patch Links --
https://github.com/whatwg/url/pull/793.patch
https://github.com/whatwg/url/pull/793.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/url/pull/793
You are receiving this because you are subscribed to this thread.
Message ID: <whatwg/url/pull/793@github.com>
Received on Tuesday, 26 September 2023 07:26:04 UTC