Re: [w3c/pointerlock] Add lock options to requestPointerLock (#49)

@marcoscaceres commented on this pull request.



> +            <li>If the request was not started from an [=engagement gesture=]
+            and the {{Document}} has not previously released a successful Pointer
+            Lock with {{Document/exitPointerLock()}}:

Also, this should have been checked way earlier... probably the first thing this method should check is if it has transient activation or not.... and return a promise rejected. Also, if you are passing the option, maybe we don't need to fire the event? 

Having both models doesn't seem ideal. Sending the parameter should opt you into the promise model.   

-- 
Reply to this email directly or view it on GitHub:
https://github.com/w3c/pointerlock/pull/49#discussion_r1373691578
You are receiving this because you are subscribed to this thread.

Message ID: <w3c/pointerlock/pull/49/review/1700466137@github.com>