Re: [w3c/permissions] Introduce Browser Permissions for WebDriver BiDi (PR #425)

@miketaylr commented on this pull request.



> +                    browser.SetPermissionParameters = {
+                      descriptor: browser.PermissionDescriptor,
+                      state: browser.PermissionState,
+                      ? context: browsingContext.BrowsingContext,
+                      ? origin: text,
+                    }
+                  </pre>
+                </dd>
+                <dt>Result Type</dt>
+                <dd>
+                  <pre class="cddl">
+                    EmptyResult
+                  </pre>
+                </dd>
+             </dl>
+             <div algorithm="remote end steps for permissions.setPermission">

+1, you can either create a new variable to capture `parameters.state` somewhere before step 4 (in classic), and pass it into an algorithm with a better name than `to 'foo bar' with state`, or just pass in `parameters.state` directly to said algorithm. 

-- 
Reply to this email directly or view it on GitHub:
https://github.com/w3c/permissions/pull/425#discussion_r1394989432
You are receiving this because you are subscribed to this thread.

Message ID: <w3c/permissions/pull/425/review/1733235715@github.com>