- From: Tim Nguyen <notifications@github.com>
- Date: Mon, 22 May 2023 15:38:18 -0700
- To: whatwg/fullscreen <fullscreen@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Monday, 22 May 2023 22:38:23 UTC
@nt1m approved this pull request. Looks fine aside from my one comment. > + <li><p><a>Request removal from the top layer</a> given <var>element</var>. + + <li><a>Add to the top layer</a> given <var>element</var>. Should this be using immediate removal rather than requesting removal? Transitions wouldn't work here since we're adding it immediately back to the top layer. -- Reply to this email directly or view it on GitHub: https://github.com/whatwg/fullscreen/pull/223#pullrequestreview-1437811747 You are receiving this because you are subscribed to this thread. Message ID: <whatwg/fullscreen/pull/223/review/1437811747@github.com>
Received on Monday, 22 May 2023 22:38:23 UTC