- From: Philip Jägenstedt <notifications@github.com>
- Date: Mon, 22 May 2023 04:09:16 -0700
- To: whatwg/fullscreen <fullscreen@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <whatwg/fullscreen/pull/223/review/1436382155@github.com>
@foolip commented on this pull request. Changes to adapt to https://github.com/w3c/csswg-drafts/commit/038516478f4cfb0b405291b67d845b77face09b5 and stick with `<var>` as the rest of the spec does. > @@ -68,17 +69,18 @@ is an <a>ordered set</a> of (<a>string</a>, <a>element</a>) <a>tuples</a>. It is <li><p>Set <var>element</var>'s <a>fullscreen flag</a>. - <li><p><a for="top layer">Add</a> <var>element</var> to <var>element</var>'s <a>node document</a>'s - <a>top layer</a>. + <li><p><a>Request removal from the top layer</a> given |element|'s <a>node document</a> and |element|. ```suggestion <li><p><a>Request removal from the top layer</a> given <var>element</var>. ``` > @@ -68,17 +69,18 @@ is an <a>ordered set</a> of (<a>string</a>, <a>element</a>) <a>tuples</a>. It is <li><p>Set <var>element</var>'s <a>fullscreen flag</a>. - <li><p><a for="top layer">Add</a> <var>element</var> to <var>element</var>'s <a>node document</a>'s - <a>top layer</a>. + <li><p><a>Request removal from the top layer</a> given |element|'s <a>node document</a> and |element|. + + <li><a>Add to the top layer</a> given |element|'s <a>node document</a> and |element|. ```suggestion <li><a>Add to the top layer</a> given <var>element</var>. ``` > </ol> <p>To <dfn>unfullscreen an <var>element</var></dfn>, unset <var>element</var>'s -<a>fullscreen flag</a> and <a>iframe fullscreen flag</a> (if any), and <a for=set>remove</a> it from -its <a>node document</a>'s <a>top layer</a>. +<a>fullscreen flag</a> and <a>iframe fullscreen flag</a> (if any), and +<a>remove from the top layer immediately</a> given |element|'s <a>node document</a> and |element|. ```suggestion <a>remove from the top layer immediately</a> given <var>element</var>. ``` > @@ -117,10 +119,10 @@ these steps: <li><p>Otherwise, <a lt="unfullscreen an element">unfullscreen <var>node</var></a>. <li> - <p>If <var>document</var>'s <a>top layer</a> <a for=set>contains</a> <var>node</var>, - <a for=set>remove</a> <var>node</var> from <var>document</var>'s <a>top layer</a>. + <p>If <var>document</var>'s <a for=Document>top layer</a> <a for=set>contains</a> <var>node</var>, + <a>remove from the top layer immediately</a> given <var>document</var> and <var>node</var>. ```suggestion <a>remove from the top layer immediately</a> given <var>node</var>. ``` -- Reply to this email directly or view it on GitHub: https://github.com/whatwg/fullscreen/pull/223#pullrequestreview-1436382155 You are receiving this because you are subscribed to this thread. Message ID: <whatwg/fullscreen/pull/223/review/1436382155@github.com>
Received on Monday, 22 May 2023 11:09:21 UTC