- From: Domenic Denicola <notifications@github.com>
- Date: Sun, 21 May 2023 23:56:49 -0700
- To: whatwg/fetch <fetch@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Monday, 22 May 2023 06:56:54 UTC
@domenic approved this pull request. LGTM but I think "return nothing" can be assumed in some cases. > @@ -615,7 +616,8 @@ given a <a for=/>header name</a> <var>name</var> and a string <var>type</var> fr <p>To <dfn export for="header list" id=concept-header-list-set-structured-header>set a structured field value</dfn> given a <a for=/>tuple</a> (<a for=/>header name</a> <var>name</var>, <a>structured field value</a> -<var>structuredValue</var>), in a <a for=/>header list</a> <var>list</var>, run these steps: +<var>structuredValue</var>), in a <a for=/>header list</a> <var>list</var>, run these steps. They +return nothing. Not necessary for the setter-type algorithms IMO. -- Reply to this email directly or view it on GitHub: https://github.com/whatwg/fetch/pull/1660#pullrequestreview-1435902343 You are receiving this because you are subscribed to this thread. Message ID: <whatwg/fetch/pull/1660/review/1435902343@github.com>
Received on Monday, 22 May 2023 06:56:54 UTC