- From: Philip Jägenstedt <notifications@github.com>
- Date: Wed, 17 May 2023 02:29:25 -0700
- To: whatwg/fullscreen <fullscreen@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <whatwg/fullscreen/pull/223/review/1430210203@github.com>
@foolip commented on this pull request. A bunch of style changes to keep this spec's more archaic style, and also to match how the algorithms are invoked with how it's done in HTML. > +[=Request removal from the top layer=] for |element| from its [=node document=], then +[=add to the top layer|add it to the top layer=] of its [=node document=]. ```suggestion <a>Request removal from the top layer</a> given |element|'s <a>node document</a> and |element|, then <a>add to the top layer</a> given |element|'s <a>node document</a> and |element|. ``` > @@ -56,21 +57,22 @@ stated otherwise it is unset. <p>All <a for=/>documents</a> have an associated <dfn export>fullscreen element</dfn>. The <a>fullscreen element</a> is the topmost <a>element</a> in the <a for=/>document</a>'s -<a>top layer</a> whose <a>fullscreen flag</a> is set, if any, and null otherwise. +[=Document/top layer=] whose <a>fullscreen flag</a> is set, if any, and null otherwise. ```suggestion <a for=Document>top layer</a> whose <a>fullscreen flag</a> is set, if any, and null otherwise. ``` > @@ -81,7 +83,7 @@ its <a>node document</a>'s <a>top layer</a>. <li><p>If <var>document</var>'s <a>fullscreen element</a> is null, terminate these steps. <li><p><a lt="unfullscreen an element">Unfullscreen elements</a> whose <a>fullscreen flag</a> is - set, within <var>document</var>'s <a>top layer</a>, except for <var>document</var>'s + set, within <var>document</var>'s [=Document/top layer=], except for <var>document</var>'s ```suggestion set, within <var>document</var>'s <a for=Document>top layer</a>, except for <var>document</var>'s ``` > + <p>If <var>document</var>'s [=Document/top layer=] <a for=set>contains</a> <var>node</var>, + <a>remove from the top layer immediately</a> <var>node</var> from <var>document</var>'s + [=Document/top layer=]. ```suggestion <p>If <var>document</var>'s <a for=Document>top layer</a> <a for=set>contains</a> <var>node</var>, <a>remove from the top layer immediately</a> given <var>document</var> and <var>node</var>. ``` > - <p class=note>Other specifications can add and remove elements from <a>top layer</a>, so + <p class=note>Other specifications can add and remove elements from [=Document/top layer=], so ```suggestion <p class=note>Other specifications can add and remove elements from <a for=Document>top layer</a>, so ``` > @@ -400,9 +403,9 @@ getter steps are: </div> <p>A <a>document</a> is said to be a <dfn>simple fullscreen document</dfn> if there is exactly one -<a>element</a> in its <a>top layer</a> that has its <a>fullscreen flag</a> set. +<a>element</a> in its [=Document/top layer=] that has its <a>fullscreen flag</a> set. ```suggestion <a>element</a> in its <a for=Document>top layer</a> that has its <a>fullscreen flag</a> set. ``` > -<p class=note>A <a>document</a> with two <a>elements</a> in its <a>top layer</a> can be a +<p class=note>A <a>document</a> with two <a>elements</a> in its [=Document/top layer=] can be a ```suggestion <p class=note>A <a>document</a> with two <a>elements</a> in its <a for=Document>top layer</a> can be a ``` > @@ -436,7 +439,7 @@ could be an open <{dialog}> element. <p class=note>This is the set of documents for which the <a>fullscreen element</a> will be <a lt="unfullscreen an element">unfullscreened</a>, but the last document in <var>docs</var> might - have more than one <a>element</a> in its <a>top layer</a> with the <a>fullscreen flag</a> set, + have more than one <a>element</a> in its [=Document/top layer=] with the <a>fullscreen flag</a> set, ```suggestion have more than one <a>element</a> in its <a for=Document>top layer</a> with the <a>fullscreen flag</a> set, ``` > @@ -745,6 +661,13 @@ delivered with the <a>document</a> through which it is nested. <p>This prevents e.g. content from third parties to go fullscreen without explicit permission. +<h2 id=old-links class=no-num oldids="new-stacking-layer, top-layer, top-layer-add, ::backdrop-pseudo-element, css-pe-backdrop"> +Appendix A: Previously-Hosted Definitions</h2> + +This specification previously hosted the definitions of <a selector>::backdrop</a> +and the concept of the document's [=Document/top layer=]. ```suggestion and the concept of the document's <a for=Document>top layer</a>. ``` -- Reply to this email directly or view it on GitHub: https://github.com/whatwg/fullscreen/pull/223#pullrequestreview-1430210203 You are receiving this because you are subscribed to this thread. Message ID: <whatwg/fullscreen/pull/223/review/1430210203@github.com>
Received on Wednesday, 17 May 2023 09:29:31 UTC