- From: Tab Atkins Jr. <notifications@github.com>
- Date: Tue, 16 May 2023 16:35:56 -0700
- To: whatwg/fullscreen <fullscreen@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Tuesday, 16 May 2023 23:36:02 UTC
@tabatkins commented on this pull request. > <p>To <dfn>unfullscreen an <var>element</var></dfn>, unset <var>element</var>'s -<a>fullscreen flag</a> and <a>iframe fullscreen flag</a> (if any), and <a for=set>remove</a> it from -its <a>node document</a>'s <a>top layer</a>. +<a>fullscreen flag</a> and <a>iframe fullscreen flag</a> (if any), and +<a>request removal from the top layer</a> for it from its <a>node document</a>. Hm, that's a reasonable argument. I'm okay with removing it immediately when unfullscreening, as this is indeed somewhat of a special case. @mfreed/@foolip does this sound okay to y'all too? -- Reply to this email directly or view it on GitHub: https://github.com/whatwg/fullscreen/pull/223#discussion_r1195782158 You are receiving this because you are subscribed to this thread. Message ID: <whatwg/fullscreen/pull/223/review/1429579637@github.com>
Received on Tuesday, 16 May 2023 23:36:02 UTC