- From: Philip Jägenstedt <notifications@github.com>
- Date: Mon, 15 May 2023 03:17:41 -0700
- To: whatwg/fullscreen <fullscreen@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Monday, 15 May 2023 10:17:46 UTC
@foolip commented on this pull request. > <p>All <a for=/>documents</a> have an associated <dfn>list of pending fullscreen events</dfn>, which is an <a>ordered set</a> of (<a>string</a>, <a>element</a>) <a>tuples</a>. It is initially empty. -<p>To <dfn>fullscreen an <var>element</var></dfn>, set <var>element</var>'s <a>fullscreen flag</a> -and <a for="top layer">add</a> it to its <a>node document</a>'s <a>top layer</a>. +<p>To <dfn>fullscreen an <var>element</var></dfn>, set <var>element</var>'s <a>fullscreen flag</a>. +If <var>element</var> is not currently [=in the top layer=] of its <a>node document</a>, I think here we should first check if the element is in top layer and if so remove it immediately. That will have the effect of moving it to the top of the stack. -- Reply to this email directly or view it on GitHub: https://github.com/whatwg/fullscreen/pull/223#discussion_r1193631743 You are receiving this because you are subscribed to this thread. Message ID: <whatwg/fullscreen/pull/223/review/1426233130@github.com>
Received on Monday, 15 May 2023 10:17:46 UTC