- From: Anne van Kesteren <notifications@github.com>
- Date: Tue, 09 May 2023 10:14:43 -0700
- To: whatwg/fetch <fetch@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <whatwg/fetch/pull/1614/review/1419105364@github.com>
@annevk commented on this pull request. @domenic it would be great if you could do another pass as well. > - <dd><p>Takes an algorithm that will be passed a <a for=/>response</a>. Indicates the network is - done transmitting the response. This does not read <a for=/>response</a>'s - <a for=response>body</a>. + <p>This is the most common way in which invokers handle a <a for=/>response</a>, for example + <a lt="fetch a classic script">scripts</a> and <a lt="fetch a style resource">style resources</a>. + The <a for=/>response</a>'s <a for=response>body</a> is obtained in its entirety into a + <a>byte sequence</a>, and then processed by the client. + + <p>To process a <a for=/>response</a> upon completion, pass an algorithm as the + <a for=fetch><i>processResponseConsumeBody</i></a> argument of <a for=/>fetch</a>. The given + algorithm is passed a <a for=/>response</a> and null, failure, or a <a>byte sequence</a>. + The second argument would be null if, for example, the <a for=/>response</a> is a + <a>network error</a>, has a <a>null body status</a> (e.g. 204), or if the <a for=/>request</a>'s + <a for=request>method</a> is `<code>HEAD</code>. It would be failure if there was an I/O error + while reading the <a for=response>body</a>, or a <a>byte sequence</a> representing the + successfully obtained <a for=response>body</a>. Maybe turn this into a dl list? It's getting rather unwieldy. There are also some editorial issues: no comma after "e.g.", no closing backtick, last sentence reads a little odd. -- Reply to this email directly or view it on GitHub: https://github.com/whatwg/fetch/pull/1614#pullrequestreview-1419105364 You are receiving this because you are subscribed to this thread. Message ID: <whatwg/fetch/pull/1614/review/1419105364@github.com>
Received on Tuesday, 9 May 2023 17:14:49 UTC