- From: Mason Freed <notifications@github.com>
- Date: Tue, 09 May 2023 01:57:53 -0700
- To: whatwg/fullscreen <fullscreen@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <whatwg/fullscreen/pull/223/c1539088416@github.com>
> @mfreed7 I think that preserving the "In other words, element is moved to the end of top layer if it is already present" behavior of the current spec has some merits. It makes for a less strange API, avoiding the situation where a request appears to succeed but it doesn't actually change anything. Yeah, I think I agree. And it sounds like there's support from others above as well. Sounds like we should go this direction. I'll land the WPT with that behavior (A/B/A leaves A topmost). > For dialogs and popovers, is there any reason they shouldn't also allow this flip-flopping behavior? I don't want to go overboard with consistency, just want to check. We could talk about dialog, I suppose. Nicely, there shouldn't be compat issues since `showModal()` throws on an already-showing dialog today. However, I don't think we should do this flip-flopping for popovers. The popover stacking logic is complex, and I worry that we'll run into weird situations. In all of these cases, I really like that the "add to top layer" algorithm will not support auto-flip-flopping, and we instead have to consider what's the best behavior for each top layer consumer API. -- Reply to this email directly or view it on GitHub: https://github.com/whatwg/fullscreen/pull/223#issuecomment-1539088416 You are receiving this because you are subscribed to this thread. Message ID: <whatwg/fullscreen/pull/223/c1539088416@github.com>
Received on Tuesday, 9 May 2023 08:57:58 UTC