- From: Jan-Ivar Bruaroey <notifications@github.com>
- Date: Thu, 04 May 2023 13:41:33 -0700
- To: whatwg/streams <streams@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Thursday, 4 May 2023 20:41:38 UTC
@jan-ivar commented on this pull request.
This looks great to me! I'll ping some Mozilla folks to respond on the standards repo.
> @@ -6388,6 +6420,10 @@ for="value-with-size">value</dfn> and <dfn for="value-with-size">size</dfn>.
performs the following steps:
1. Assert: |container| has \[[queue]] and \[[queueTotalSize]] internal slots.
+ 1. If |container| has an \[[isOwning]] internal slot whose value is true, perform the following steps until |container|.\[[queue]]
+ is [=list/is empty|empty=]:
Nit: why not
```suggestion
[=list/is empty=]:
```
?
--
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/1271#pullrequestreview-1413700585
You are receiving this because you are subscribed to this thread.
Message ID: <whatwg/streams/pull/1271/review/1413700585@github.com>
Received on Thursday, 4 May 2023 20:41:38 UTC