Re: [w3c/screen-orientation] Editorial: combine safety check steps into new section (PR #251)

@marcoscaceres commented on this pull request.



> +        <p>
+          The <dfn>common safety checks</dfn> for a {{Document}}
+          |document:Document| are the following steps:
+        </p>

Ok, sooooo... these all throw now. And yes, the IDL layer would automatically wrap the exceptions. 

However, just from the sake of clarity and consistency, I'd still like to use "Return a promise rejected with X" for `.lock()`. I've had instances in the past of reviewers getting confused about methods throwing even though they always return a promise. 

Similarly, for .unlock(), just for clarity, I have it re-throw and abort the steps. 



-- 
Reply to this email directly or view it on GitHub:
https://github.com/w3c/screen-orientation/pull/251#discussion_r1184539289
You are receiving this because you are subscribed to this thread.

Message ID: <w3c/screen-orientation/pull/251/review/1412281803@github.com>