Re: [whatwg/dom] Handle attribute changes after changing attribute (PR #1176)

@josepharhar commented on this pull request.



>   <li><a for=list>Remove</a> <var>attribute</var> from <var>attribute</var>'s
  <a for=Attr>element</a>'s <a for=Element>attribute list</a>.
 
  <li><p>Set <var>attribute</var>'s <a for=Attr>element</a> to null.
+
+ <li><p><a>Handle attribute changes</a> for <var>attribute</var> with <var>attribute</var>'s
+ <a for=Attr>element</a>, <var>attribute</var>'s <a for=Attr>value</a>, and null.

> Presumably we need to cache attribute's element beforehand?

Done

> Also, it's surprising that for element removal it runs before, but for attribute removal it's after.
> 
> Did you double check what implementations do here?

There's things that run before and after element removal in chromium: https://github.com/whatwg/dom/pull/1185#issuecomment-1520926675

As for attribute changes, I just did a quick look and it does not look like there is anything which runs prior to an attribute change in chromium.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/dom/pull/1176#discussion_r1181796380
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/dom/pull/1176/review/1407947313@github.com>