- From: fergald <notifications@github.com>
- Date: Thu, 27 Jul 2023 21:29:12 -0700
- To: whatwg/fetch <fetch@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <whatwg/fetch/pull/1647/review/1551321502@github.com>
@fergald commented on this pull request. > -<a>done flag</a> is unset or <a for=request>keepalive</a> is false, -<a for="fetch controller">terminate</a> the <a for="fetch group">fetch record</a>'s -<a for="fetch record">controller</a>. +<p>When a <a for=fetch>fetch group</a> <var>fetchGroup</var> is +<dfn export for="fetch group" id=concept-fetch-group-terminate>terminated</dfn>: + +<ol> + <li><p>For each associated <a for="fetch group">fetch record</a> <var>record</var>, + if <var>record</var>'s <a for="fetch record">controller</a> is non-null and + <var>record</var>'s <a for="fetch record">request</a>'s <a>done flag</a> is unset and + <a for=request>keepalive</a> is false, <a for="fetch controller">terminate</a> <var>record</var>'s + <a for="fetch record">controller</a>. + + <li><p><a for=list>For each</a> <a for="fetch group">deferred fetch record</a> + <var>deferredRecord</var> in <var>fetchGroup</var>'s + <a for="fetch group">deferred fetch records</a>: If the result of atomically exchanging the value This is bit tricky. This is fundamentally multi-threaded in that there is the document's thread but we sometimes want the request to be triggered from outside of that (and in some cases while the document's event loop is paused). Is it possible to spec it so that the document is authoritative for the state of the request and that any other thread can post a request to the document's thread to try update it? This is Chrome's implementation and it's unclear that we want to constrain the implementation to match. It's also unclear to me how the document's thread can handle such a request if its event loop is paused. I guess it could be a different event loop that does not get paused. Maybe we can start off being more proscriptive and if someone ever wants to make an implementation that works differently but achieves the same results, we could reword it to be more flexible. -- Reply to this email directly or view it on GitHub: https://github.com/whatwg/fetch/pull/1647#discussion_r1277076660 You are receiving this because you are subscribed to this thread. Message ID: <whatwg/fetch/pull/1647/review/1551321502@github.com>
Received on Friday, 28 July 2023 04:29:17 UTC