- From: Domenic Denicola <notifications@github.com>
- Date: Tue, 04 Jul 2023 17:52:51 -0700
- To: whatwg/webidl <webidl@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <whatwg/webidl/pull/1179/review/1513514484@github.com>
@domenic approved this pull request. LGTM with nit > @@ -14679,6 +14694,7 @@ Their [=serialization steps=], given <var>value</var> and <var>serialized</var>, <ol> <li>Set <var>serialized</var>.\[[Name]] to <var>value</var>'s [=DOMException/name=].</li> <li>Set <var>serialized</var>.\[[Message]] to <var>value</var>'s [=DOMException/message=].</li> + <li>Set <var>serialized</var>.\[[Cause]] to the [=sub-serialization=] of the value of <var>value</var>'s [=DOMException/cause=].</li> ```suggestion <li>Set <var>serialized</var>.\[[Cause]] to the [=sub-serialization=] of <var>value</var>'s [=DOMException/cause=].</li> ``` > @@ -14689,6 +14705,7 @@ Their [=deserialization steps=], given <var>value</var> and <var>serialized</var <ol> <li>Set <var>value</var>'s [=DOMException/name=] to <var>serialized</var>.\[[Name]].</li> <li>Set <var>value</var>'s [=DOMException/message=] to <var>serialized</var>.\[[Message]].</li> + <li>Set <var>value</var>'s [=DOMException/cause=] to the [=sub-deserialization=] of the value of <var>serialized</var>.\[[Cause]].</li> ```suggestion <li>Set <var>value</var>'s [=DOMException/cause=] to the [=sub-deserialization=] of <var>serialized</var>.\[[Cause]].</li> ``` -- Reply to this email directly or view it on GitHub: https://github.com/whatwg/webidl/pull/1179#pullrequestreview-1513514484 You are receiving this because you are subscribed to this thread. Message ID: <whatwg/webidl/pull/1179/review/1513514484@github.com>
Received on Wednesday, 5 July 2023 00:52:57 UTC