- From: Domenic Denicola <notifications@github.com>
- Date: Tue, 10 Jan 2023 00:08:58 -0800
- To: whatwg/fetch <fetch@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <whatwg/fetch/pull/1587/review/1241622429@github.com>
@domenic approved this pull request. LGTM with nits > @@ -564,6 +559,10 @@ consistency. <h4 id=terminology-headers>Headers</h4> +<p class=note>HTTP generally refers to headers as ‘fields’ or ‘header fields’. The web platform uses +the more colloquial term ‘header’. [[HTTP]] The fancy quotes here are a bit strange; non-fancy double-quotes would be more usual. > <p>A <dfn id=concept-stale-while-revalidate-response>stale-while-revalidate response</dfn> is a -<a for=/>response</a> that is not a <a>fresh response</a> and whose -<a href=https://datatracker.ietf.org/doc/html/rfc7234#section-4.2.3>current age</a> is within the -<a href=https://datatracker.ietf.org/doc/html/rfc5861#section-3>stale-while-revalidate lifetime</a>. +<a for=/>response</a> that is not a <a>fresh response</a> and whose <a>current age</a> is within the +<a href=https://httpwg.org/specs/rfc5861.html#rfc.section.3>stale-while-revalidate lifetime</a>. Add to the links block? > [[!COOKIES]]), then: <ol> <li><p>Let <var>cookies</var> be the result of running the "cookie-string" algorithm (see - <a href=https://datatracker.ietf.org/doc/html/rfc6265#section-5.4>section 5.4</a> of + <a href=https://httpwg.org/specs/rfc6265.html#cookie>section 5.4</a> of Maybe use a section name instead of number while you're here. Or change this to the cross-reference style below you used for chapters? Same for other cookie spec updates as below. -- Reply to this email directly or view it on GitHub: https://github.com/whatwg/fetch/pull/1587#pullrequestreview-1241622429 You are receiving this because you are subscribed to this thread. Message ID: <whatwg/fetch/pull/1587/review/1241622429@github.com>
Received on Tuesday, 10 January 2023 08:09:11 UTC