Re: [w3c/ServiceWorker] Skip executing fetch handlers if it is no-op. (PR #1672)

@yoshisatoyanagisawa commented on this pull request.



> +              1. If |callback| does not have <code>handleEvent</code> property, then return false.
+              1. If |callback|'s <code>handleEvent</code> property is not a [=function=], then return false.
+              1. If a [=function body=] of |callback|'s <code>handleEvent</code> property is not empty (i.e. either [=statement=] or [=declaration=] exist), return false.

Considering https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/bindings/core/v8/js_event_listener.cc;l=14;drc=609b81c1b05359d844df8786169ba20f230152b4 behavior, it might be fair to say that this would also see handleEvent.  I tried to update this with  https://webidl.spec.whatwg.org/#call-a-user-objects-operation 10 upon your offline suggestion.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/w3c/ServiceWorker/pull/1672#discussion_r1112605404
You are receiving this because you are subscribed to this thread.

Message ID: <w3c/ServiceWorker/pull/1672/review/1306771733@github.com>