- From: Marcos Cáceres <notifications@github.com>
- Date: Mon, 18 Dec 2023 21:51:20 -0800
- To: w3c/gamepad <gamepad@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Tuesday, 19 December 2023 05:51:26 UTC
@marcoscaceres commented on this pull request. > + The {{GamepadHapticActuator/effects}} getter steps are: + </p> + <ol> + <li>Return [=this=].{{GamepadHapticActuator/[[effects]]}}. + </li> + </ol> + </dd> + <dt> + <dfn>playEffect()</dfn> method + </dt> + <dd> + <p> + The {{GamepadHapticActuator/playEffect()}} method steps are: + </p> + <ol> + <li>If |params:GamepadEffectParameters| does not describe a [=valid I don't think we should be allowed to even get into the situation where we need a validator (i.e., we don't ever need to run custom validators for each value)... Consider, by merely changing the the WebIDL value for `startDelay` from double to an `unsigned long long` with a default of 0, we've already solved for the validity check without needing any prose (and it already gives you a TypeError for free). **I think we can get rid of "valid effect" entirely.** -- Reply to this email directly or view it on GitHub: https://github.com/w3c/gamepad/pull/190#discussion_r1430942661 You are receiving this because you are subscribed to this thread. Message ID: <w3c/gamepad/pull/190/review/1788140794@github.com>
Received on Tuesday, 19 December 2023 05:51:26 UTC