- From: Marcos Cáceres <notifications@github.com>
- Date: Mon, 18 Dec 2023 21:42:25 -0800
- To: w3c/gamepad <gamepad@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <w3c/gamepad/pull/190/review/1788133650@github.com>
@marcoscaceres commented on this pull request.
> + The {{GamepadHapticActuator/playEffect()}} method steps, called with
+ {{GamepadHapticEffectType}} |type:GamepadHapticEffectType| and
+ {{GamepadEffectParameters}} |params:GamepadEffectParameters |, are:
+ </p>
+ <ol class="algorithm">
+ <li>If |params:GamepadEffectParameters| does not describe a [=valid
+ effect=] of type |type:GamepadHapticEffectType|, return [=a promise
+ rejected with=] reason {{TypeError}}.
+ </li>
+ <li>Let |document:Document?| be the [=current settings object=]'s
+ [=relevant global object=]'s [=associated `Document`=].
+ </li>
+ <li>If |document| is `null` or |document| is not [=Document/fully
+ active=] or |document|'s [=Document/visibility state=] is
+ `"hidden"`, return [=a promise resolved with=]
+ {{GamepadHapticsResult/"preempted"}}.
These still look like exceptional situations to me... we should be retiring [=a promise rejected with=] with something here.
--
Reply to this email directly or view it on GitHub:
https://github.com/w3c/gamepad/pull/190#pullrequestreview-1788133650
You are receiving this because you are subscribed to this thread.
Message ID: <w3c/gamepad/pull/190/review/1788133650@github.com>
Received on Tuesday, 19 December 2023 05:42:32 UTC