- From: Marcos Cáceres <notifications@github.com>
- Date: Mon, 11 Dec 2023 21:29:21 -0800
- To: w3c/gamepad <gamepad@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Tuesday, 12 December 2023 05:29:28 UTC
@marcoscaceres commented on this pull request. > + required. + </p> + <p> + {{GamepadEffectParameters/startDelay}} and + {{GamepadEffectParameters/duration}} set the duration of the + initial delay before after initiating the effect before the + effect will be started + </p> + <p> + {{GamepadEffectParameters/startDelay}} sets the duration of the + delay after {{GamepadHapticActuator/playEffect()}} is called + until vibration is started, in milliseconds. During the delay + interval, the actuator must not vibrate. An effect with negative + {{GamepadEffectParameters/startDelay}} is not a [=valid effect=]. + If the {{GamepadEffectParameters/startDelay}} is not specified, + the default delay is 0 milliseconds. Why is startDelay a `double` when it doesn't allow negative and it represents milliseconds anyway? Should this just just a `unsigned long long` instead? -- Reply to this email directly or view it on GitHub: https://github.com/w3c/gamepad/pull/190#pullrequestreview-1776655643 You are receiving this because you are subscribed to this thread. Message ID: <w3c/gamepad/pull/190/review/1776655643@github.com>
Received on Tuesday, 12 December 2023 05:29:28 UTC