- From: Ming-Ying Chung <notifications@github.com>
- Date: Tue, 22 Aug 2023 22:01:25 -0700
- To: whatwg/fetch <fetch@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Wednesday, 23 August 2023 05:01:31 UTC
@mingyc commented on this pull request. > + + <li><p>Let <var>request</var> be <var>requestObject</var>'s <a for=Request>request</a>. + + <li><p>If <var>request</var>'s <a for=request>URL</a>'s <a for=url>scheme</a> is not an + <a>HTTP(S) scheme</a> then throw a {{TypeError}}. + + <li><p>If <var>request</var>'s <a for=request>URL</a> is not a + [=potentially trustworthy url=], then throw a {{SecurityError}}. + + <li><p>Let <var>backgroundTimeout</var> be null. + + <li><p>If <var>init</var> is given and <var>init</var>["<code>backgroundTimeout</code>"] + <a for=map>exists</a> then set <var>backgroundTimeout</var> to + <var>init</var>["<code>backgroundTimeout</code>"]. + + <li><p>If <var>backgroundTimeout</var> is not a {{DOMHighResTimeStamp}} then throw a {{TypeError}}. ``` If backgroundTimeout is not a [ DOMHighResTimeStamp ] then throw a [ TypeError ]. ``` Should it also throws TypeError if backgroundTimeout is negative? DOMHighResTimeStamp according to its spec is a double, which can be negative, but a negative timeout makes no sense for a duration. -- Reply to this email directly or view it on GitHub: https://github.com/whatwg/fetch/pull/1647#pullrequestreview-1590751812 You are receiving this because you are subscribed to this thread. Message ID: <whatwg/fetch/pull/1647/review/1590751812@github.com>
Received on Wednesday, 23 August 2023 05:01:31 UTC