- From: Noam Rosenthal <notifications@github.com>
- Date: Sun, 13 Aug 2023 00:23:37 -0700
- To: whatwg/fetch <fetch@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <whatwg/fetch/pull/1647/review/1575707806@github.com>
@noamr commented on this pull request. > -<a>done flag</a> is unset or <a for=request>keepalive</a> is false, -<a for="fetch controller">terminate</a> the <a for="fetch group">fetch record</a>'s -<a for="fetch record">controller</a>. +<p>When a <a for=fetch>fetch group</a> <var>fetchGroup</var> is +<dfn export for="fetch group" id=concept-fetch-group-terminate>terminated</dfn>: + +<ol> + <li><p>For each associated <a for="fetch group">fetch record</a> <var>record</var>, + if <var>record</var>'s <a for="fetch record">controller</a> is non-null and + <var>record</var>'s <a for="fetch record">request</a>'s <a>done flag</a> is unset and + <a for=request>keepalive</a> is false, <a for="fetch controller">terminate</a> <var>record</var>'s + <a for="fetch record">controller</a>. + + <li><p><a for=list>For each</a> <a for="fetch group">deferred fetch record</a> + <var>deferredRecord</var> in <var>fetchGroup</var>'s + <a for="fetch group">deferred fetch records</a>: If the result of atomically exchanging the value > Instead of saying "atomically exchanging" we should just have a list of steps. Within the same thread everything always happens in order. (Or if we really need this primitive we should add it to Infra, but I don't think we do.) Yea I don't get how this can be done without either atomically exchanging or running a task on a paused document's event queue which was in a previous revision of this PR. I don't mind going in either direction (adding atomic exchanges to infra or adding some kind of way to run tasks on a paused document) but seems like @annevk has another alternative in mind? -- Reply to this email directly or view it on GitHub: https://github.com/whatwg/fetch/pull/1647#discussion_r1292698254 You are receiving this because you are subscribed to this thread. Message ID: <whatwg/fetch/pull/1647/review/1575707806@github.com>
Received on Sunday, 13 August 2023 07:23:44 UTC