Re: [whatwg/fullscreen] Hide popovers when making an element fullscreen (PR #204) from Tim Nguyen on 2023-04-28 (public-webapps-github@w3.org from April 2023)

From: Tim Nguyen <notifications@github.com>
Date: Fri, 28 Apr 2023 08:52:08 -0700
To: whatwg/fullscreen <fullscreen@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <whatwg/fullscreen/pull/204/c1527762896@github.com>

> @nt1m if I'm reading [WebKit/WebKit#11155](https://github.com/WebKit/WebKit/pull/11155) correctly, you implemented this behavior in `FullscreenManager.cpp`, but I'm unsure if all of the `isInPopoverShowingState()` checks are intended to always pass, or if there are also cases where a fullscreen request will be rejected because of an open popover?

I think our implementation matches this PR, the `isInPopoverShowingState()` checks are for the "fullscreen element ready check". We could probably refactor to make this more clear, but that's how things are currently setup.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fullscreen/pull/204#issuecomment-1527762896
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/fullscreen/pull/204/c1527762896@github.com>

Received on Friday, 28 April 2023 15:52:14 UTC