Re: [w3c/screen-orientation] Editorial: combine safety check steps into new section (PR #251)

@annevk commented on this pull request.



> +        <p>
+          The <dfn>common safety checks</dfn> for a {{Document}}
+          |document:Document| are the following steps:
+        </p>

You should make these throw an exception. Web IDL will do the conversion from a thrown exception to a rejected promise. Returning an exception is very weird.

Alternatively you could return a(n) (string) enum and branch on that.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/w3c/screen-orientation/pull/251#pullrequestreview-1406029690
You are receiving this because you are subscribed to this thread.

Message ID: <w3c/screen-orientation/pull/251/review/1406029690@github.com>