Re: [whatwg/fullscreen] Hide popovers when making an element fullscreen (PR #204) from Philip Jägenstedt on 2023-04-25 (public-webapps-github@w3.org from April 2023)

From: Philip Jägenstedt <notifications@github.com>
Date: Tue, 25 Apr 2023 09:26:16 -0700
To: whatwg/fullscreen <fullscreen@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <whatwg/fullscreen/pull/204/c1522083539@github.com>

@nt1m if I'm reading https://github.com/WebKit/WebKit/pull/11155 correctly, you implemented this behavior in `FullscreenManager.cpp`, but I'm unsure if all of the `isInPopoverShowingState()` checks are intended to always pass, or if there are also cases where a fullscreen request will be rejected because of an open popover?

If that PR matches this spec, can we consider that support from WebKit to make this change? I'd like to get it merged because it makes https://github.com/whatwg/fullscreen/pull/223 easier to understand, in particular it guarantees (in the spec) that certain combinations of fullscreen and popovers can't happen.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fullscreen/pull/204#issuecomment-1522083539
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/fullscreen/pull/204/c1522083539@github.com>

Received on Tuesday, 25 April 2023 16:26:21 UTC