Re: [whatwg/fetch] Editorial: update args for collect an HTTP quoted string (PR #1641)

@annevk commented on this pull request.

Thanks for tackling this. Just a couple nits. And maybe we should link the downstream PRs from the commit message?

> @@ -446,7 +446,7 @@ preferred. Unlike <a>ASCII whitespace</a> this excludes U+000C FF.
 <p>To
 <dfn export lt="collect an HTTP quoted string|collecting an HTTP quoted string">collect an HTTP quoted string</dfn>
 from a <a for=/>string</a> <var>input</var>, given a <a>position variable</a> <var>position</var>
-and optionally an <var>extract-value flag</var>, run these steps:
+and a boolean <var>extract-value</var> (default false), run these steps:

```suggestion
and an optional boolean <var>extract-value</var> (default false):
```

> @@ -495,7 +495,7 @@ and optionally an <var>extract-value flag</var>, run these steps:
     </ol>
   </ol>
 
- <li><p>If the <var>extract-value flag</var> is set, then return <var>value</var>.
+ <li><p>If the <var>extract-value</var> is true, then return <var>value</var>.

```suggestion
 <li><p>If <var>extract-value</var> is true, then return <var>value</var>.
```

> @@ -506,7 +506,7 @@ and optionally an <var>extract-value flag</var>, run these steps:
   <tr>
    <th>Input
    <th>Output
-   <th>Output with the <var>extract-value flag</var> set
+   <th>Output with the <var>extract-value</var> set to true

```suggestion
   <th>Output with <var>extract-value</var> set to true
```

-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fetch/pull/1641#pullrequestreview-1399213229
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/fetch/pull/1641/review/1399213229@github.com>

Received on Tuesday, 25 April 2023 06:33:18 UTC