Re: [whatwg/dom] Handle attribute changes after changing attribute (PR #1176)

@emilio commented on this pull request.



>   <li><p><a for=list>Replace</a> <var>oldAttr</var> by <var>newAttr</var> in <var>oldAttr</var>'s
  <a for=Attr>element</a>'s <a for=Element>attribute list</a>.
 
  <li><p>Set <var>newAttr</var>'s <a for=Attr>element</a> to <var>oldAttr</var>'s
  <a for=Attr>element</a>.
 
  <li><p>Set <var>oldAttr</var>'s <a for=Attr>element</a> to null.
+
+ <li><p><a>Handle attribute changes</a> for <var>oldAttr</var> with <var>oldAttr</var>'s
+ <a for=Attr>element</a>, <var>oldAttr</var>'s <a for=Attr>value</a>, and <var>newAttr</var>'s

You need to handle attribute changes with `newAttr`'s element, etc. `oldAttr`'s element was assigned to null the line before.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/dom/pull/1176#pullrequestreview-1398325633
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/dom/pull/1176/review/1398325633@github.com>

Received on Monday, 24 April 2023 15:44:30 UTC