Re: [whatwg/streams] Add support for ReadableStream "owning" type (PR #1271)

@MattiasBuelens commented on this pull request.

Apologies, still missed a few `undefined`s in the reference implementation.

> @@ -155,7 +155,7 @@ function TransformStreamDefaultControllerEnqueue(controller, chunk) {
   // accept TransformStreamDefaultControllerEnqueue() calls.
 
   try {
-    ReadableStreamDefaultControllerEnqueue(readableController, chunk);
+    ReadableStreamDefaultControllerEnqueue(readableController, chunk, undefined);

```suggestion
    ReadableStreamDefaultControllerEnqueue(readableController, chunk, []);
```

> @@ -392,10 +392,10 @@ function ReadableStreamDefaultTee(stream, cloneForBranch2) {
           // }
 
           if (canceled1 === false) {
-            ReadableStreamDefaultControllerEnqueue(branch1._controller, chunk1);
+            ReadableStreamDefaultControllerEnqueue(branch1._controller, chunk1, undefined);

```suggestion
            ReadableStreamDefaultControllerEnqueue(branch1._controller, chunk1, []);
```

>            }
           if (canceled2 === false) {
-            ReadableStreamDefaultControllerEnqueue(branch2._controller, chunk2);
+            ReadableStreamDefaultControllerEnqueue(branch2._controller, chunk2, undefined);

```suggestion
            ReadableStreamDefaultControllerEnqueue(branch2._controller, chunk2, []);
```

-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/1271#pullrequestreview-1393795376
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/streams/pull/1271/review/1393795376@github.com>