Re: [whatwg/streams] Add support for ReadableStream "owning" type (PR #1271)

@ricea commented on this pull request.



> @@ -2950,13 +2966,19 @@ The following abstract operations support the implementation of the
 <div algorithm>
  <dfn abstract-op lt="ReadableStreamDefaultControllerEnqueue"
  id="readable-stream-default-controller-enqueue">ReadableStreamDefaultControllerEnqueue(|controller|,
- |chunk|)</dfn> performs the following steps:
+ |chunk|, |transferList|)</dfn> performs the following steps:
 
  1. If ! [$ReadableStreamDefaultControllerCanCloseOrEnqueue$](|controller|) is false, return.

Do you mean if existing code calls `controller.enqueue(chunk, { transfer: [ chunk ] })` it will suddenly start throwing an exception? That seems unlikely enough that I wouldn't worry about it. Even if someone was doing that, their code was arguably wrong since the second argument was never doing anything.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/1271#discussion_r1168366861
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/streams/pull/1271/review/1387553407@github.com>

Received on Monday, 17 April 2023 08:40:41 UTC