- From: Joshua Bell <notifications@github.com>
- Date: Thu, 13 Apr 2023 10:05:50 -0700
- To: w3c/IndexedDB <IndexedDB@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <w3c/IndexedDB/pull/401/review/1383847592@github.com>
@inexorabletash approved this pull request. lgtm with some follow-up items for me > internal slot is NaN. - * [=ECMAScript/String=] primitive values. - * [=ECMAScript/ArrayBuffer=] objects (or views on buffers such as - [=ECMAScript/Uint8Array=]). - * [=ECMAScript/Array=] objects, where every item is defined, is itself a valid + * {{String}} primitive values. + * {{ArrayBuffer}} objects (or views on buffers such as This now links to WebIDL's ArrayBuffer, which is probably fine. Just noting the change. > @@ -773,8 +754,8 @@ following type-specific properties: <tr><th>Type</th><th>Properties</th></tr> <tr><td>{{Blob}}</td><td>{{Blob/size}}, {{Blob/type}}</td></tr> <tr><td>{{File}}</td><td>{{File/name}}, {{File/lastModified}}</td></tr> - <tr><td>[=ECMAScript/Array=]</td><td>`length`</td></tr> - <tr><td>[=ECMAScript/String=]</td><td>`length`</td></tr> + <tr><td>{{Array}}</td><td>`length`</td></tr> Note to self that we can probably linkify length here now > @@ -3349,7 +3330,7 @@ The <dfn method for=IDBObjectStore>openCursor(|query|, |direction|)</dfn> method [=cursor/range=] set to |range|, and [=cursor/key only flag=] set to false. -1. Let |operation| be an algorithm to run [=iterate a cursor=] with the [=ECMAScript/current Realm=] |cursor|. +1. Let |operation| be an algorithm to run [=iterate a cursor=] with [=ECMAScript/the current Realm record=] |cursor|. Oops, there should be an "and" between record and cursor. Existing glitch. -- Reply to this email directly or view it on GitHub: https://github.com/w3c/IndexedDB/pull/401#pullrequestreview-1383847592 You are receiving this because you are subscribed to this thread. Message ID: <w3c/IndexedDB/pull/401/review/1383847592@github.com>
Received on Thursday, 13 April 2023 17:05:55 UTC