Re: [w3c/screen-orientation] Editorial: fix queue a task to fire change an event (PR #250)

@annevk commented on this pull request.



> @@ -834,22 +834,29 @@ <h2>
         |screenOrientation|'s {{ScreenOrientation/[[angle]]}}, abort these
         steps.
         </li>
-        <li>Set |screenOrientation|'s {{ScreenOrientation/[[angle]]}} to
-        |angle|.
-        </li>
-        <li>Set |screenOrientation|'s {{ScreenOrientation/[[type]]}} to |type|.
-        </li>
-        <li>[=Fire an event=] named "<a data-link-for=
-        "ScreenOrientation">change</a>" at |screenOrientation|.
+        <li>[=Queue a task=] on the [=user interaction task source=] with

Queue a task is the legacy algorithm. You want one of the ones that takes more arguments, such as queue a global task.

> @@ -834,22 +834,29 @@ <h2>
         |screenOrientation|'s {{ScreenOrientation/[[angle]]}}, abort these
         steps.
         </li>
-        <li>Set |screenOrientation|'s {{ScreenOrientation/[[angle]]}} to
-        |angle|.
-        </li>
-        <li>Set |screenOrientation|'s {{ScreenOrientation/[[type]]}} to |type|.
-        </li>
-        <li>[=Fire an event=] named "<a data-link-for=
-        "ScreenOrientation">change</a>" at |screenOrientation|.
+        <li>[=Queue a task=] on the [=user interaction task source=] with
+        |document|'s [=relevant global object=] to perform the following
+        substeps:

We typically say "steps" these days.

>          <li>[=Set/For each=] |doc:Document| in |descendantDocs|, [=queue a
-        global task=] on the [=DOM manipulation task source=] with |doc|'s
-        [=relevant global object=] to run the [=screen orientation change
-        steps=] with |doc|.
+        task=] on the [=user interaction task source=] with |doc|'s [=relevant
+        global object=] to run the [=screen orientation change steps=] with
+        |doc|.

This seems like it's queueing a task to queue a task. That seems bad? Perhaps "screen orientation change steps" shouldn't queue a task itself after all?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/w3c/screen-orientation/pull/250#pullrequestreview-1382712737
You are receiving this because you are subscribed to this thread.

Message ID: <w3c/screen-orientation/pull/250/review/1382712737@github.com>