Re: [whatwg/streams] Add support for ReadableStream "transfer" type (PR #1271)

@ricea commented on this pull request.

General approach looks good. I made some early nitpicks.

We can bikeshed whether `type: 'transfer'` or a new optional flag `transfer: true` is better. `type: 'transfer'` makes it easier to extend TransformStream. `transfer: true` maintains the 1:1 relationship between types and controllers.

> @@ -3065,6 +3084,9 @@ The following abstract operations support the implementation of the
  1. Let |startAlgorithm| be an algorithm that returns undefined.
  1. Let |pullAlgorithm| be an algorithm that returns [=a promise resolved with=] undefined.
  1. Let |cancelAlgorithm| be an algorithm that returns [=a promise resolved with=] undefined.
+ 1. Let |cancelAlgorithm| be an algorithm that returns [=a promise resolved with=] undefined.

This line appears to be duplicated.

> @@ -3065,6 +3084,9 @@ The following abstract operations support the implementation of the
  1. Let |startAlgorithm| be an algorithm that returns undefined.
  1. Let |pullAlgorithm| be an algorithm that returns [=a promise resolved with=] undefined.
  1. Let |cancelAlgorithm| be an algorithm that returns [=a promise resolved with=] undefined.
+ 1. Let |cancelAlgorithm| be an algorithm that returns [=a promise resolved with=] undefined.
+ 1. Let |isTransferring| be true if |underlyingSourceDict|["{{UnderlyingSource/pull}}"] is

```suggestion
 1. Let |isTransferring| be true if |underlyingSourceDict|["{{UnderlyingSource/type}}"] is
```

> @@ -6596,6 +6626,18 @@ The following abstract operations are a grab-bag of utilities.
  1. Return ? [$StructuredDeserialize$](|serialized|, [=the current Realm=]).
 </div>
 
+<div algorithm>
+ <dfn abstract-op lt="StructuredTransferOrSerialize">StructuredTransferOrSerialize(|value|)</dfn>

Maybe "StructuredTransferOrClone" would be a clearer name?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/1271#pullrequestreview-1377178645
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/streams/pull/1271/review/1377178645@github.com>