- From: Kagami Sascha Rosylight <notifications@github.com>
- Date: Mon, 03 Apr 2023 00:59:57 -0700
- To: whatwg/streams <streams@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Monday, 3 April 2023 08:00:10 UTC
@saschanaz commented on this pull request.
LGTM, thanks for the cleanup!
> @@ -6808,10 +6784,38 @@ They should only [=ArrayBufferView/create=] a new {{ArrayBufferView}} to pass to
[=ReadableStream/enqueue=] when the [=ReadableStream/current BYOB request view=] is null, or when
they have more bytes on hand than the [=ReadableStream/current BYOB request view=]'s
Should we explicitly say the below algorithm doesn't enqueue "when they have more bytes on hand than ..."?
Also, https://github.com/w3c/webtransport/pull/487 throws in that case, should it enqueue instead? Not sure it's fine to implicitly ignore the byob request view.
--
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/1263#pullrequestreview-1368481125
You are receiving this because you are subscribed to this thread.
Message ID: <whatwg/streams/pull/1263/review/1368481125@github.com>
Received on Monday, 3 April 2023 08:00:10 UTC