Re: [w3c/permissions] WIP: Define a permission store (closes #384) (PR #390)

@johannhof commented on this pull request.



> +          </li>
+          <li>
+            Otherwise, [=list/append=] |newEntry| to the [=global permission store=].
+          </li>
+        </ol>
+        </p>
+        <p>
+        To <dfn class="export">remove a permission store entry</dfn> from the [=global permission store=] given a name, key and descriptor, run these steps:
+        <ol class="algorithm">
+          <li>
+          [=list/Remove=] the [=entry=] with the name |name|, key |key| and descriptor |descriptor| from the [=global permission store=].
+          </li>
+        </ol>
+        </p>
+        <p>
+        A <dfn class="export">permission store key</dfn> is a [=tuple=] of ([=origin=] top-level origin, [=origin=] embedded origin).

So while trying to sketch out the comparison algorithm I realized that having null / optional fields in this key is just a security / correctness footgun and set both now, see latest changes. It's a bit weird in the case where only the top-level origin is set, though.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/w3c/permissions/pull/390#discussion_r1026381199
You are receiving this because you are subscribed to this thread.

Message ID: <w3c/permissions/pull/390/review/1186016162@github.com>