Re: [w3c/push-api] Rewrite .subscribe() to fix various bugs (PR #350)

@marcoscaceres commented on this pull request.



>          </li>
-        <li>Return |promise| and continue the following steps asynchronously.
+        <li>If the |options| argument does not include a non-null value for the
+        {{PushSubscriptionOptionsInit/applicationServerKey}} member, and the <a>push service</a>
+        requires one to be given, return [=a promise rejected with=] a {{"NotSupportedError"}}
+        {{DOMException}}.
+        </li>
+        <li>Let |promise| be [=a new promise=].
+        </li>
+        <li>Let |global:Window| be [=this=]' [=relevant global object=].

Ah, yeah. good point. I'll remove the type. 

-- 
Reply to this email directly or view it on GitHub:
https://github.com/w3c/push-api/pull/350#discussion_r908124030
You are receiving this because you are subscribed to this thread.

Message ID: <w3c/push-api/pull/350/review/1021231085@github.com>