Re: [w3c/manifest] Add support for defining a theme color for both light & dark modes (prefers color scheme) (#975)

As an aside, we should bring back https://github.com/whatwg/html/pull/6444 ... 

@FluorescentHallucinogen, you are not wrong... and I agree that should be supported (HTML spec issue). 

However, we are going somewhat for developer convenience here. I think it does get a little unmanageable if you have to keep multiple manifest for both `hreflang` and `media`. For example:

```HTML 
<link
  rel="manifest"
  href="./fr/manifest.dark.json"
  media="(prefers-color-scheme: dark)"
  hreflang="fr"
/>

<link
  rel="manifest"
  href="./en/manifest.dark.json"
  media="(prefers-color-scheme: dark)"
  hreflang="en"
/>
```

And so on... 

FWIW, I'm not sold on `override` object... I'd prefer just to keep a flat structure (at least, I'm not seeing any added value).

```
{
 name: "Good dog", 
 "translations": {
    "fr": {
      "name": "Bon chien",
      "description": "Une application pour chiens",
      "screenshots": []
    }
  },
  "user_preferences": {
    "color_scheme_dark": {
      "icons": []
    }
  }
}
``` 

In terms or processing, `"translations"` should probably apply first, followed by "user_preferences".  Having said that, we need to consider if certain things shouldn't be affected by `user_preferences` (e.g., the `name` and `short_name`). Similarly, an icon of the shortcut might change, but changing the shortcut's `name` would be weird. 


-- 
Reply to this email directly or view it on GitHub:
https://github.com/w3c/manifest/issues/975#issuecomment-1152046787
You are receiving this because you are subscribed to this thread.

Message ID: <w3c/manifest/issues/975/1152046787@github.com>

Received on Friday, 10 June 2022 07:13:08 UTC