- From: Marcos Cáceres <notifications@github.com>
- Date: Wed, 08 Jun 2022 18:50:42 -0700
- To: w3c/gamepad <gamepad@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Thursday, 9 June 2022 01:50:54 UTC
@marcoscaceres commented on this pull request.
> </p>
<pre class="idl">
[Exposed=Window]
interface GamepadHapticActuator {
readonly attribute GamepadHapticActuatorType type;
+ boolean canPlayEffectType(GamepadHapticEffectType type);
+ Promise<GamepadHapticsResult> playEffect(
+ GamepadHapticEffectType type,
+ optional GamepadEffectParameters params = {});
Promise<boolean> pulse(double value, double duration);
isn't "pulse" also an effect? Maybe it could be `playEffect("pulse")`... otherwise, you end up with situations like:
```
.pulse(a,b);
.playEffect(obj);
```
Which would conflict with each other. Having a single `.playEffect()` call would avoid that.
```
.playEffect("dual-rumble").then(()=> .playEffect("pulse"))
```
--
Reply to this email directly or view it on GitHub:
https://github.com/w3c/gamepad/pull/163#pullrequestreview-1000626472
You are receiving this because you are subscribed to this thread.
Message ID: <w3c/gamepad/pull/163/review/1000626472@github.com>
Received on Thursday, 9 June 2022 01:50:54 UTC