Re: [w3c/gamepad] extensions: Add vibrationActuator and dual-rumble effect (PR #163)

@nondebug commented on this pull request.



> +        <dt>
+          <dfn>playEffect()</dfn> method
+        </dt>
+        <dd>
+          <p>
+            The {{GamepadHapticActuator/playEffect()}} method steps are:
+          </p>
+          <ol>
+            <li>If |params:GamepadEffectParameters| does not describe a [=valid
+            effect=] of type |type:GamepadHapticEffectType|, return [=a promise
+            resolved with=] {{GamepadHapticsResult/"invalid-parameter"}}.
+            </li>
+            <li>Let |document| be the [=current settings object=]'s [=relevant
+            global object=]'s [=associated `Document`=].
+            </li>
+            <li>If |document| is `null` or |document| is not [=Document/fully

Which error would you use?

I feel a preempted effect is not an error because it's expected you'll sometimes interrupt an effect to cut it short or replace it with a new effect. I think visibility changes should be handled as if the effect were preempted by a call to `reset()`.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/w3c/gamepad/pull/163#discussion_r892969715
You are receiving this because you are subscribed to this thread.

Message ID: <w3c/gamepad/pull/163/review/1000587676@github.com>