Re: [w3c/push-api] Rewrite .subscribe() to fix various bugs (PR #350)

@marcoscaceres commented on this pull request.



>            <li>Let |subscription| be a new <a>push subscription</a>.
           </li>
-          <li>Set the `options` attribute of |subscription| to be a copy of |options|.
+          <li>Let |options:PushSubscriptionOptions| be a newly created {{PushSubscriptionOptions}}
+          object, initializing its attribute with the corresponding values of |optionsDictionary|.

```suggestion
          object, initializing its attributes with the corresponding values of |optionsDictionary|.
```


-- 
Reply to this email directly or view it on GitHub:
https://github.com/w3c/push-api/pull/350#pullrequestreview-994332438
You are receiving this because you are subscribed to this thread.

Message ID: <w3c/push-api/pull/350/review/994332438@github.com>