- From: Noam Rosenthal <notifications@github.com>
- Date: Wed, 27 Jul 2022 09:26:29 -0700
- To: whatwg/fetch <fetch@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <whatwg/fetch/pull/1468/review/1052798919@github.com>
@noamr commented on this pull request. > @@ -301,6 +301,9 @@ following <a for=struct>items</a>: [[RESOURCE-TIMING]] [[NAVIGATION-TIMING]] <dt><dfn export for="response body info" id="fetch-timing-info-decoded-body-size">decoded size</dfn> (default 0) <dd>A number. + <dt><dfn export for="response body info" id="fetch-timing-info-response-status">response > Okay, just to be sure I understand. We would pass in the status as a new parameter to [Mark resource time](https://w3c.github.io/resource-timing/#dfn-mark-resource-timing) which would in turn pass it to [Setup the resource timing entry](https://w3c.github.io/resource-timing/#dfn-setup-the-resource-timing-entry) where we would use it to set the entry's `responseStatus`. Exactly > > > Also, as we talked on the Chromium CL, I don't think we should automatically make this TAO-protected rather than CORS-protected. It's not exactly timing information. > > Yeah, we don't want to. I am a bit unsure as to where the exact place to specify this is. Does it make sense to add this to [fetch response handover](https://fetch.spec.whatwg.org/#fetch-finale) as well - If the CORS check fails pass in `0` as the status to `Mark resource timing` Actually I don't think you need to do anything. If this is a no-cors request, `response` would already be an [opaque filtered response](https://fetch.spec.whatwg.org/#concept-filtered-response-opaque) with a status of 0. -- Reply to this email directly or view it on GitHub: https://github.com/whatwg/fetch/pull/1468#discussion_r931266882 You are receiving this because you are subscribed to this thread. Message ID: <whatwg/fetch/pull/1468/review/1052798919@github.com>
Received on Wednesday, 27 July 2022 16:26:41 UTC