Re: [whatwg/fetch] Add response status to response body info (PR #1468)

@annevk commented on this pull request.



> @@ -301,6 +301,9 @@ following <a for=struct>items</a>: [[RESOURCE-TIMING]] [[NAVIGATION-TIMING]]
  <dt><dfn export for="response body info" id="fetch-timing-info-decoded-body-size">decoded
  size</dfn> (default 0)
  <dd>A number.
+ <dt><dfn export for="response body info" id="fetch-timing-info-response-status">response
+ status</dfn> (default 0)

One minor thing here that I notice is incorrect for some other fields as well is that `fetch.bs` shouldn't wrap inside phrasing elements such as `<dfn>` so you can more easily search for the terms inside of them.

> @@ -5536,6 +5539,9 @@ optional boolean <var>forceNewConnection</var> (default false), run these steps:
 
        <li><p>Let <var>status</var> be the HTTP response's status code.

It might be worth having a follow-up issue on how to better integrate with HTTP or indicate that's what's happening. We basically want to map an HTTP response to a Fetch response. There has been some discussion about this also with the HTTP WG, but I don't think we'll get anything formal out of that.

> @@ -301,6 +301,9 @@ following <a for=struct>items</a>: [[RESOURCE-TIMING]] [[NAVIGATION-TIMING]]
  <dt><dfn export for="response body info" id="fetch-timing-info-decoded-body-size">decoded
  size</dfn> (default 0)
  <dd>A number.
+ <dt><dfn export for="response body info" id="fetch-timing-info-response-status">response

I think there might be an existing problem here in that an opaque response wouldn't expose body info.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fetch/pull/1468#pullrequestreview-1054365407
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/fetch/pull/1468/review/1054365407@github.com>

Received on Thursday, 28 July 2022 15:50:09 UTC