Re: [whatwg/url] Split forbidden host/domain code points, and add all C0 controls and add U+007F to the latter (PR #685) from Anne van Kesteren on 2022-01-25 (public-webapps-github@w3.org from January 2022)

From: Anne van Kesteren <notifications@github.com>
Date: Tue, 25 Jan 2022 07:51:40 -0800
To: whatwg/url <url@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <whatwg/url/pull/685/review/862491317@github.com>

@annevk approved this pull request.

This looks good to me. I don't think the conformance requirements end up needing adjusting (and it seems like this fixes a small problem for "valid opaque-host string"), although for "valid domain string" it's a bit unclear due to the imperative nature of its definition.

I'd appreciate a second review.



-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/url/pull/685#pullrequestreview-862491317
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/url/pull/685/review/862491317@github.com>

Received on Tuesday, 25 January 2022 15:51:52 UTC