Re: [whatwg/streams] Release reader immediately when shutting down a pipe (PR #1208)

@domenic commented on this pull request.

It sounds like either option (1) or (2) is observably equivalent, right? My instinct would then be to go with whichever is easiest to spec (probably (2)?), and then explain that it's equivalent to the other one.

If we go with (2) and explain it's equivalent to (1), we're explaining the weird dance and saying that perhaps a more natural implementation would be (1), if you're less into code reuse than we are.

If we go with (1) and explain it's equivalent to (2), then we're explaining how despite doing some tricky direct manipulations of the internals, we're not actually doing anything which you couldn't already do with the public API.

> +   1. If |reader| [=implements=] {{ReadableStreamBYOBReader}}, perform
+      ! [$ReadableStreamBYOBReaderRelease$](|reader|).
+   1. Otherwise, perform ! [$ReadableStreamDefaultReaderRelease$](|reader|).

Mind factoring this out into a separate PR?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/1208#pullrequestreview-856004206
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/streams/pull/1208/review/856004206@github.com>