Re: [whatwg/streams] Release reader immediately when shutting down a pipe (PR #1208) from Mattias Buelens on 2022-01-16 (public-webapps-github@w3.org from January 2022)

From: Mattias Buelens <notifications@github.com>
Date: Sat, 15 Jan 2022 16:49:12 -0800
To: whatwg/streams <streams@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <whatwg/streams/pull/1208/review/853618011@github.com>

@MattiasBuelens commented on this pull request.



> +   1. If |reader| [=implements=] {{ReadableStreamBYOBReader}}, perform
+      ! [$ReadableStreamBYOBReaderRelease$](|reader|).
+   1. Otherwise, perform ! [$ReadableStreamDefaultReaderRelease$](|reader|).

Drive-by fix: the user agent is allowed to use a BYOB reader for the pipe (see step 8), but now we have *separate* `Release()` abstract ops for default and BYOB readers. (Before #1168, we had a single `ReadableStreamGenericReaderRelease` that worked for both.)

-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/1208#pullrequestreview-853618011
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/streams/pull/1208/review/853618011@github.com>

Received on Sunday, 16 January 2022 00:49:24 UTC