- From: Domenic Denicola <notifications@github.com>
- Date: Mon, 10 Jan 2022 15:06:39 -0800
- To: whatwg/streams <streams@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Monday, 10 January 2022 23:06:52 UTC
@domenic approved this pull request.
LGTM with final token nit. I can work on reviewing the tests again. But it'd be great to have @ricea and/or @nidhijaju confirm this is a good direction.
Given Safari and Firefox haven't yet implemented readable byte streams I'm comfortable calling this a bugfix that falls under their general already-expressed interest in readable byte streams, as long as we get at least a Chromium sanity check. Of course Safari and Firefox engineer review and thoughts would be highly welcome if they have the time!
> @@ -3196,6 +3249,30 @@ The following abstract operations support the implementation of the
|controller|.[=ReadableByteStreamController/[[queueTotalSize]]=] + |byteLength|.
</div>
+<div algorithm>
+ <dfn abstract-op lt="ReadableByteStreamControllerEnqueueClonedChunkToQueue">ReadableByteStreamControllerEnqueueClonedChunkToQueue(|controller|,
Linebreak after `abstract-op`
--
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/1168#pullrequestreview-848446352
You are receiving this because you are subscribed to this thread.
Message ID: <whatwg/streams/pull/1168/review/848446352@github.com>
Received on Monday, 10 January 2022 23:06:52 UTC