- From: Andrew Williams <notifications@github.com>
- Date: Fri, 11 Feb 2022 08:41:59 -0800
- To: whatwg/storage <storage@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Friday, 11 February 2022 16:42:11 UTC
@recvfrom commented on this pull request. > @@ -229,6 +229,17 @@ settings object</a> <var>environment</var>, run these steps: <li><p>Return <var>key</var>. </ol> +<p>To determine whether a <a>storage key</a> <var>A</var> +<dfn export for="storage key" id=concept-storage-key-equals lt=equal>equals</dfn> <var>B</var>, run I modeled it off of this: https://github.com/whatwg/url/blob/main/url.bs#L1144-L1146 There they didn't repeat the type for `B`, but I agree that it's helpful for maximum clarity. Also, manually adding the id lets us prepend `concept` to it, which seems like something that's done in a lot of places (without the id specified, bikeshed makes it `storage-key-equals`). I'm happy to drop it, though. -- Reply to this email directly or view it on GitHub: https://github.com/whatwg/storage/pull/134#discussion_r804824855 You are receiving this because you are subscribed to this thread. Message ID: <whatwg/storage/pull/134/review/880424575@github.com>
Received on Friday, 11 February 2022 16:42:11 UTC